[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific fi
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files |
Date: |
Mon, 28 Jun 2010 18:03:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5 |
On 06/28/10 17:42, Blue Swirl wrote:
> On Mon, Jun 28, 2010 at 2:50 PM, Jes Sorensen <address@hidden> wrote:
>> I figured out what was causing it. qemu-options.def has an
>> #ifdef MAP_POPULATE in it, which isn't being set without sys/mmap.h
>> being included. Pretty much every other #ifdef in qemu-options.def are
>> based on CONFIG_foo settings or things like _WIN32 which do not change
>> depending on header file inclusion.
>>
>> I think the easiest fix is to just add sys/mmap.h to the include list in
>> os-posix.c, so I just posted a patch for that. Though, in principle we
>> really shouldn't base qemu-options.def settings on defines pulled in
>> from system header files.
>
> I think more flags should be added to arch_mask field, like
> QEMU_ARCH_LINUX, QEMU_ARCH_POSIX and QEMU_ARCH_WIN32. Then the #ifdefs
> should be removed. Prealloc command line flag stuff should be
> conditional to CONFIG_LINUX only, there should be another check for
> MAP_POPULATE where mem_preallocate is set.
>
> Alternatively, we could have more arch_mask flags like QEMU_MAP_POPULATE.
Yeah, the problem with tying it to CONFIG_LINUX is that older version of
Linux may not support it. Looking through the list, MAP_POPULATE is
really an oddball in there though, so maybe it would be cleaner to catch
it via configure and then use CONFIG_MAP_POPULATE or something like that?
Cheers,
Jes
- [Qemu-devel] [PATCH 11/17] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c, (continued)
- [Qemu-devel] [PATCH 11/17] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c, Jes . Sorensen, 2010/06/10
- [Qemu-devel] [PATCH 15/17] Make os_change_process_uid and os_change_root os-posix.c local, Jes . Sorensen, 2010/06/10
- [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Jes . Sorensen, 2010/06/10
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Frank Arnold, 2010/06/25
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Jes Sorensen, 2010/06/25
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Frank Arnold, 2010/06/25
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Frank Arnold, 2010/06/25
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Jes Sorensen, 2010/06/28
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Jes Sorensen, 2010/06/28
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Blue Swirl, 2010/06/28
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files,
Jes Sorensen <=
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Blue Swirl, 2010/06/28
- Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files, Jes Sorensen, 2010/06/28
- [Qemu-devel] Re: [PATCH 14/17] Move daemonize handling to OS specific files, Paolo Bonzini, 2010/06/28
[Qemu-devel] [PATCH 16/17] Move line-buffering setup to OS specific files., Jes . Sorensen, 2010/06/10
[Qemu-devel] [PATCH 17/17] Move set_proc_name() to OS specific files., Jes . Sorensen, 2010/06/10
Re: [Qemu-devel] [PATCH v4 00/17] clean up vl.c code, Blue Swirl, 2010/06/12