[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/25] QMP: Rename query handlers
From: |
Miguel Di Ciurcio Filho |
Subject: |
Re: [Qemu-devel] [PATCH 01/25] QMP: Rename query handlers |
Date: |
Tue, 7 Dec 2010 10:28:25 -0200 |
On Mon, Dec 6, 2010 at 4:23 PM, Luiz Capitulino <address@hidden> wrote:
> Query handlers still carry their human monitor name. This commit
> renames all of them to a more QMP-like name.
>
> For example, do_info_version() is renamed to qmp_query_version().
> - * do_info_balloon(): Balloon information
> + * qmp_query_balloon(): Balloon information
> *
> * Make an asynchronous request for balloon info. When the request completes
> * a QDict will be returned according to the following specification:
> @@ -106,7 +106,7 @@ void monitor_print_balloon(Monitor *mon, const QObject
> *data)
> * "major_page_faults": 142, "minor_page_faults": 239245,
> * "free_mem": 1014185984, "total_mem": 1044668416 }
> */
> -int do_info_balloon(Monitor *mon, MonitorCompletion cb, void *opaque)
> +int qmp_query_balloon(Monitor *mon, MonitorCompletion cb, void *opaque)
> {
If the idea is to detach the human monitor from the QMP API, is there
any reason to keep passing `Monitor *mon` to qmp_* functions? In some
parts of the code NULL is being passed.
Regards,
Miguel
- [Qemu-devel] [PATCH v1 00/25]: Monitor: First step on an internal QMP API, Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 01/25] QMP: Rename query handlers, Luiz Capitulino, 2010/12/06
- Re: [Qemu-devel] [PATCH 01/25] QMP: Rename query handlers,
Miguel Di Ciurcio Filho <=
- [Qemu-devel] [PATCH 03/25] Monitor: Drop balloon handlers comments, Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 02/25] QMP: Drop user_print usage from the qmp_query_cmds[] table, Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 04/25] Monitor: Move qmp_query_version() up in monitor.c, Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 06/25] Monitor: Convert qemu_chr_info_print() into qemu_chr_info(), Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 05/25] Monitor: Convert do_info_version_print() into do_info_version(), Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 07/25] Monitor: Convert bdrv_info_print() into bdrv_info(), Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 08/25] Monitor: Convert bdrv_stats_print() into bdrv_stats(), Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 09/25] Monitor: Move qmp_query_cpus() up in monitor.c, Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 10/25] Monitor: Convert monitor_print_cpus() into do_info_cpus(), Luiz Capitulino, 2010/12/06