[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/5] ARM: Fix VQSHL of signed 64 bit values
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 2/5] ARM: Fix VQSHL of signed 64 bit values |
Date: |
Tue, 7 Dec 2010 14:13:42 +0000 |
From: Juha Riihimäki <address@hidden>
Add a missing '-' which meant that we were misinterpreting the shift
argument for VQSHL of 64 bit signed values and treating almost every
shift value as if it were an extremely large right shift.
Signed-off-by: Juha Riihimäki <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
---
target-arm/neon_helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c
index 5e6452b..d29b884 100644
--- a/target-arm/neon_helper.c
+++ b/target-arm/neon_helper.c
@@ -610,7 +610,7 @@ uint64_t HELPER(neon_qshl_s64)(CPUState *env, uint64_t
valop, uint64_t shiftop)
SET_QC();
val = (val >> 63) & ~SIGNBIT64;
}
- } else if (shift <= 64) {
+ } else if (shift <= -64) {
val >>= 63;
} else if (shift < 0) {
val >>= -shift;
--
1.6.3.3
- [Qemu-devel] [PATCH 0/5] ARM: fix VQSHL (register), Peter Maydell, 2010/12/07
- [Qemu-devel] [PATCH 4/5] ARM: remove pointless else clause in VQSHL of u64, Peter Maydell, 2010/12/07
- [Qemu-devel] [PATCH 5/5] ARM: Correct result in saturating cases for VQSHL of s8/16/32, Peter Maydell, 2010/12/07
- [Qemu-devel] [PATCH 3/5] ARM: Fix VQSHL of signed 64 bit values by shift counts >= 64, Peter Maydell, 2010/12/07
- [Qemu-devel] [PATCH 2/5] ARM: Fix VQSHL of signed 64 bit values,
Peter Maydell <=
- [Qemu-devel] [PATCH 1/5] ARM: Fix arguments passed to VQSHL helpers, Peter Maydell, 2010/12/07
- Re: [Qemu-devel] [PATCH 0/5] ARM: fix VQSHL (register), Aurelien Jarno, 2010/12/27