[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [RFC][PATCH v5 09/21] virtagent: add va.getdmesg RPC
From: |
Jes Sorensen |
Subject: |
[Qemu-devel] Re: [RFC][PATCH v5 09/21] virtagent: add va.getdmesg RPC |
Date: |
Tue, 07 Dec 2010 15:37:13 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6 |
On 12/03/10 19:03, Michael Roth wrote:
> Add RPC to view guest dmesg output.
>
> Signed-off-by: Michael Roth <address@hidden>
> ---
> virtagent-server.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 46 insertions(+), 0 deletions(-)
>
> diff --git a/virtagent-server.c b/virtagent-server.c
> index a430b58..aac8f70 100644
> --- a/virtagent-server.c
> +++ b/virtagent-server.c
> @@ -83,6 +83,50 @@ EXIT_CLOSE_BAD:
> return result;
> }
>
> +/* va_getdmesg(): return dmesg output
> + * rpc return values:
> + * - dmesg output as a string
> + */
> +static xmlrpc_value *va_getdmesg(xmlrpc_env *env,
> + xmlrpc_value *param,
> + void *user_data)
> +{
> + char *dmesg_buf = NULL, cmd[256];
> + int ret;
> + xmlrpc_value *result = NULL;
> + FILE *pipe;
> +
> + SLOG("va_getdmesg()");
> +
> + dmesg_buf = qemu_mallocz(VA_DMESG_LEN + 2048);
> + sprintf(cmd, "dmesg -s %d", VA_DMESG_LEN);
What happens if the guest's dmesg buffer is larger than your hardcoded
value?
Jes
- [Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC, (continued)
- [Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC, Adam Litke, 2010/12/06
- [Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC, Jes Sorensen, 2010/12/07
- [Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC, Adam Litke, 2010/12/07
- [Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC, Jes Sorensen, 2010/12/08
- [Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC, Adam Litke, 2010/12/09
- [Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC, Michael Roth, 2010/12/09
- [Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC, Jes Sorensen, 2010/12/10
[Qemu-devel] [RFC][PATCH v5 09/21] virtagent: add va.getdmesg RPC, Michael Roth, 2010/12/03
[Qemu-devel] [RFC][PATCH v5 08/21] virtagent: add agent_viewfile qmp/hmp command, Michael Roth, 2010/12/03
[Qemu-devel] Re: [RFC][PATCH v5 08/21] virtagent: add agent_viewfile qmp/hmp command, Jes Sorensen, 2010/12/07