[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handl
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions |
Date: |
Wed, 08 Dec 2010 10:17:50 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6 |
On 12/08/10 10:15, Stefan Hajnoczi wrote:
> On Tue, Dec 07, 2010 at 04:02:03PM +0100, Jes Sorensen wrote:
>> Anything to avoid qemu_set_fd_handler17() at some point. I think using
>> __qemu_set_fd_handler() encourages people to modify that code rather
>> than copy it.
>
> I agree that qemu_set_fd_handler3() could be named something more
> meaningful. Unfortunately we can't use __qemu_set_fd_handler() because
> the C language standard reserves identifiers that start with double
> underscore for the standard library. The Linux kernel gets away with it
> because the code is freestanding but that doesn't apply to QEMU.
Hmmm you sure that is actually a rule, rather than a convention?
Either way, we can use 3 underscores, or leave the function static, in
which case the C library names are a non issue.
Cheers,
Jes
- [Qemu-devel] [RFC][PATCH v5 00/21] virtagent: host/guest RPC communication agent, Michael Roth, 2010/12/03
- [Qemu-devel] [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions, Michael Roth, 2010/12/03
- [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions, Jes Sorensen, 2010/12/07
- Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions, Michael Roth, 2010/12/07
- Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions, Jes Sorensen, 2010/12/07
- Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions, Stefan Hajnoczi, 2010/12/08
- Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions,
Jes Sorensen <=
- Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions, Stefan Hajnoczi, 2010/12/08
- Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions, Jes Sorensen, 2010/12/08
- Re: [Qemu-devel] Re: [RFC][PATCH v5 01/21] Move code related to fd handlers into utility functions, Anthony Liguori, 2010/12/08
[Qemu-devel] [RFC][PATCH v5 04/21] virtagent: transport definitions and job callbacks, Michael Roth, 2010/12/03
[Qemu-devel] [RFC][PATCH v5 02/21] Add qemu_set_fd_handler() wrappers to qemu-tools.c, Michael Roth, 2010/12/03