[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] [RFC] Emulation of GRLIB GPTimer as defined
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] [RFC] Emulation of GRLIB GPTimer as defined in GRLIB IP Core User's Manual. |
Date: |
Wed, 8 Dec 2010 22:02:48 +0100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Wed, Dec 08, 2010 at 10:39:43AM +0100, Fabien Chouteau wrote:
> On 12/08/2010 09:30 AM, Edgar E. Iglesias wrote:
> > On Tue, Dec 07, 2010 at 10:55:33AM +0100, Fabien Chouteau wrote:
> >> On 12/06/2010 06:12 PM, Blue Swirl wrote:
> >>> On Mon, Dec 6, 2010 at 9:26 AM, Fabien Chouteau<address@hidden> wrote:
> >>>> +DeviceState *grlib_gptimer_create(target_phys_addr_t base,
> >>>> + uint32_t nr_timers,
> >>>> + uint32_t freq,
> >>>> + qemu_irq *cpu_irqs,
> >>>> + int base_irq)
> >>> This function belongs to leon3.c.
> >> I don't see why. GPTimer is a peripheral and you may want to use it in
> >> an other system.
> > This might depend a bit on taste, but I agree with Blue that we shouldn't
> > clutter the device models with this kind of instantiator helper calls.
> > IMO it's better to put them higher up (e.g board code or similar).
>
> Do you mean like Xilinx devices where the instantiators are in-lined
> functions in hw/xilinx.h?
Yes, that's one way. But if you only have a single board you can also just
put the function with the board code.
Cheers
Re: [Qemu-devel] [PATCH 1/6] [RFC] Emulation of GRLIB GPTimer as defined in GRLIB IP Core User's Manual., Blue Swirl, 2010/12/06
Re: [Qemu-devel] [PATCH 1/6] [RFC] Emulation of GRLIB GPTimer as defined in GRLIB IP Core User's Manual., Edgar E. Iglesias, 2010/12/08
Re: [Qemu-devel] [PATCH 0/6] [RFC] New SPARC machine: Leon3, Artyom Tarasenko, 2010/12/06
Re: [Qemu-devel] [PATCH 0/6] [RFC] New SPARC machine: Leon3, Blue Swirl, 2010/12/06