Re: [Qemu-devel] [PATCH, RFC 3/4] prep: Fix duplicate ISA IDE IRQ

[Andreas Färber]

Am 14.12.2010 um 01:49 schrieb Andreas Färber:

> Calling isa_ide_init() twice with the same IRQ 13 fails:
>
> qemu: hardware error: isa irq 13 already assigned
>
> Use a different IRQ (14) for the second one to avoid this.
>
> Signed-off-by: Hervé Poussineau <address@hidden>
> Cc: Alexander Graf <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>

The implied question behind "RFC" is, has this been a dormant bug in  
ppc_prep.c or would this need to be fixed at ISA level (allowing two  
devices to share the same IRQ) in isa-bus.c where the above error  
message is raised?

Andreas

> ---
> hw/ppc_prep.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ppc_prep.c b/hw/ppc_prep.c
> index 3575dee..3073870 100644
> --- a/hw/ppc_prep.c
> +++ b/hw/ppc_prep.c
> @@ -76,7 +76,7 @@ qemu_log_mask(CPU_LOG_IOPORT, fmt, ## __VA_ARGS__)
> /* Constants for devices init */
> static const int ide_iobase[2] = { 0x1f0, 0x170 };
> static const int ide_iobase2[2] = { 0x3f6, 0x376 };
> -static const int ide_irq[2] = { 13, 13 };
> +static const int ide_irq[2] = { 13, 14 };