Re: [Qemu-devel] [PATCH v3 01/16] vnc: qemu can die if the client is disconnected while updating screen

[Anthony Liguori]

On 02/04/2011 02:05 AM, Corentin Chary wrote:
> agraf reported that qemu_mutex_destroy(vs->output_mutex) while failing
> in vnc_disconnect_finish().
>
> It's because vnc_worker_thread_loop() tries to unlock the mutex while
> not locked. The unlocking call doesn't fail (pthread bug ?), but
> the destroy call does.
>
> Signed-off-by: Corentin Chary<address@hidden>
>    

Applied (just this patch) to master, Thanks.

Regards,

Anthony Liguori

> ---
>   ui/vnc-jobs-async.c |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/ui/vnc-jobs-async.c b/ui/vnc-jobs-async.c
> index 6e9cf08..0b5d750 100644
> --- a/ui/vnc-jobs-async.c
> +++ b/ui/vnc-jobs-async.c
> @@ -227,6 +227,10 @@ static int vnc_worker_thread_loop(VncJobQueue *queue)
>
>           if (job->vs->csock == -1) {
>               vnc_unlock_display(job->vs->vd);
> +            /* output mutex must be locked before going to
> +             * disconnected:
> +             */
> +            vnc_lock_output(job->vs);
>               goto disconnected;
>           }
>
>