|
| From: | Avi Kivity |
| Subject: | Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset |
| Date: | Sun, 02 Oct 2011 18:39:59 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 |
On 09/28/2011 09:01 PM, Blue Swirl wrote:
On Wed, Sep 28, 2011 at 11:00 AM, Jan Kiszka<address@hidden> wrote: > As we clearly modify the PIC state on pic_reset, we also have to update > the IRQ output. This only happened on init so far. Apply this > consistently. Nack, IRQ lines shouldn't be touched on reset. The other side may not be ready for receiving the interrupt change and qemu_irqs are stateless anyway.
The way to fix it is two-phase reset:phase 1: reset internal state (-> move all outputs to reset values), don't sample inputs yet
phase 2: allow sampling inputs -- error compiling committee.c: too many arguments to function
| [Prev in Thread] | Current Thread | [Next in Thread] |