[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/6] qapi: avoid reserved keywords
|
From: |
Luiz Capitulino |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 3/6] qapi: avoid reserved keywords |
|
Date: |
Thu, 2 Aug 2012 17:52:49 -0300 |
On Thu, 02 Aug 2012 10:32:59 +0200
Markus Armbruster <address@hidden> wrote:
> Blue Swirl <address@hidden> writes:
>
> > Clang compiler complained about use of reserved word 'restrict' in SLIRP
> > and QAPI.
> >
> > Prefix C keywords with "q_", adjust SLIRP accordingly.
> >
> > Signed-off-by: Blue Swirl <address@hidden>
>
> I like this solution.
Yeah, looks good.
Would be nice to add a note to docs/writing-qmp-commands.txt (can be in an
incremental patch).
>
> Reviewed-by: Markus Armbruster <address@hidden>
>
- [Qemu-devel] [PATCH v2 0/6] Clang patches, Blue Swirl, 2012/08/01
- [Qemu-devel] [PATCH v2 1/6] sparc: fix floppy TC line setup, Blue Swirl, 2012/08/01
- [Qemu-devel] [PATCH v2 2/6] sparc: fix expression with uninitialized initial value, Blue Swirl, 2012/08/01
- [Qemu-devel] [PATCH v2 3/6] qapi: avoid reserved keywords, Blue Swirl, 2012/08/01
- [Qemu-devel] [PATCH v2 4/6] user: fix accidental AREG0 use, Blue Swirl, 2012/08/01
- [Qemu-devel] [PATCH v2 6/6] scsi-bus: remove overlapping entry, Blue Swirl, 2012/08/01
- [Qemu-devel] [PATCH v2 5/6] xilinx_axienet: avoid useless self-assignment, Blue Swirl, 2012/08/01