[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/10] block: Enable qemu_open/close to work wit
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 06/10] block: Enable qemu_open/close to work with fd sets |
Date: |
Thu, 16 Aug 2012 00:37:43 +0100 |
On 15 August 2012 14:56, Kevin Wolf <address@hidden> wrote:
> From: Corey Bryant <address@hidden>
> + /* Set/unset flags that we can with fcntl */
> + setfl_flags = O_APPEND | O_ASYNC | O_DIRECT | O_NOATIME | O_NONBLOCK;
> + dup_flags &= ~setfl_flags;
> + dup_flags |= (flags & setfl_flags);
> + if (fcntl(ret, F_SETFL, dup_flags) == -1) {
> + goto fail;
> + }
Looks like this patch caused a buildbot failure on OpenBSD:
CC osdep.o
osdep.c: In function 'qemu_dup_flags':
osdep.c:116: error: 'O_DIRECT' undeclared (first use in this function)
osdep.c:116: error: (Each undeclared identifier is reported only once
osdep.c:116: error: for each function it appears in.)
osdep.c:116: error: 'O_NOATIME' undeclared (first use in this function)
gmake: *** [osdep.o] Error 1
-- PMM
- [Qemu-devel] [PULL 00/10] Block patches, Kevin Wolf, 2012/08/15
- [Qemu-devel] [PATCH 01/10] qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg, Kevin Wolf, 2012/08/15
- [Qemu-devel] [PATCH 03/10] block: Prevent detection of /dev/fdset/ as floppy, Kevin Wolf, 2012/08/15
- [Qemu-devel] [PATCH 02/10] qapi: Introduce add-fd, remove-fd, query-fdsets, Kevin Wolf, 2012/08/15
- [Qemu-devel] [PATCH 04/10] block: Convert open calls to qemu_open, Kevin Wolf, 2012/08/15
- [Qemu-devel] [PATCH 05/10] block: Convert close calls to qemu_close, Kevin Wolf, 2012/08/15
- [Qemu-devel] [PATCH 06/10] block: Enable qemu_open/close to work with fd sets, Kevin Wolf, 2012/08/15
- Re: [Qemu-devel] [PATCH 06/10] block: Enable qemu_open/close to work with fd sets,
Peter Maydell <=
- [Qemu-devel] [PATCH 07/10] monitor: Clean up fd sets on monitor disconnect, Kevin Wolf, 2012/08/15
- [Qemu-devel] [PATCH 09/10] block: Flush parent to OS with cache=unsafe, Kevin Wolf, 2012/08/15
- [Qemu-devel] [PATCH 10/10] qemu-iotests: Fix 030 after switch to GenericError, Kevin Wolf, 2012/08/15
- [Qemu-devel] [PATCH 08/10] iscsi: Fix NULL dereferences / races between task completion and abort, Kevin Wolf, 2012/08/15
- Re: [Qemu-devel] [PULL 00/10] Block patches, Anthony Liguori, 2012/08/15