[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] qapi-types.h doesn't really need to include
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] qapi-types.h doesn't really need to include qemu-common.h |
Date: |
Mon, 20 Aug 2012 21:59:28 +0200 |
On Mon, 20 Aug 2012 12:22:10 -0300
Luiz Capitulino <address@hidden> wrote:
> On Mon, 20 Aug 2012 01:39:37 +0200
> Igor Mammedov <address@hidden> wrote:
>
> > needed to prevent build breakage when CPU becomes a child of DeviceState
> >
> > Signed-off-by: Igor Mammedov <address@hidden>
> > ---
> > scripts/qapi-types.py | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
> > index cf601ae..f34addb 100644
> > --- a/scripts/qapi-types.py
> > +++ b/scripts/qapi-types.py
> > @@ -263,7 +263,7 @@ fdecl.write(mcgen('''
> > #ifndef %(guard)s
> > #define %(guard)s
> >
> > -#include "qemu-common.h"
> > +#include <stdbool.h>
>
> Please, also include <stdint.h>, as int64_t is used in qapi-types.h.
>
> The build doesn't break probably because files including qapi-types.h are
> including <stdint.h> first.
Thanks for suggestion. I'll fix it for next respin.
>
> >
> > ''',
> > guard=guardname(h_file)))
>
--
Regards,
Igor
[Qemu-devel] [PATCH 3/5] qapi-types.h doesn't really need to include qemu-common.h, Igor Mammedov, 2012/08/19
[Qemu-devel] [PATCH 2/5] qdev: split up header so it can be used in cpu.h, Igor Mammedov, 2012/08/19
[Qemu-devel] [PATCH 4/5] cleanup error.h, included qapi-types.h aready has stdbool.h, Igor Mammedov, 2012/08/19
[Qemu-devel] [PATCH 5/5] make CPU a child of DeviceState, Igor Mammedov, 2012/08/19
Re: [Qemu-devel] [PATCH 0/5 v2] cpu: make a child of DeviceState, Stefan Weil, 2012/08/20