[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/8] migration: rename expected_time to expected
From: |
Orit Wasserman |
Subject: |
Re: [Qemu-devel] [PATCH 6/8] migration: rename expected_time to expected_downtime |
Date: |
Tue, 21 Aug 2012 13:57:59 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 08/18/2012 02:17 PM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> arch_init.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/arch_init.c b/arch_init.c
> index 0a9ca85..7eb6e86 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -538,7 +538,7 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)
> double bwidth = 0;
> int ret;
> int i;
> - uint64_t expected_time;
> + uint64_t expected_downtime;
>
> bytes_transferred_last = bytes_transferred;
> bwidth = qemu_get_clock_ns(rt_clock);
> @@ -577,24 +577,25 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)
> bwidth = qemu_get_clock_ns(rt_clock) - bwidth;
> bwidth = (bytes_transferred - bytes_transferred_last) / bwidth;
>
> - /* if we haven't transferred anything this round, force expected_time to
> a
> - * a very high value, but without crashing */
> + /* if we haven't transferred anything this round, force
> + * expected_downtime to a very high value, but without
> + * crashing */
> if (bwidth == 0) {
> bwidth = 0.000001;
> }
>
> qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
>
> - expected_time = ram_save_remaining() * TARGET_PAGE_SIZE / bwidth;
> + expected_downtime = ram_save_remaining() * TARGET_PAGE_SIZE / bwidth;
>
> DPRINTF("ram_save_live: expected(" PRIu64 ") <= max(" PRIu64 ")?\n",
> - expected_time, migrate_max_downtime());
> + expected_downtime, migrate_max_downtime());
>
> - if (expected_time <= migrate_max_downtime()) {
> + if (expected_downtime <= migrate_max_downtime()) {
> memory_global_sync_dirty_bitmap(get_system_memory());
> - expected_time = ram_save_remaining() * TARGET_PAGE_SIZE / bwidth;
> + expected_downtime = ram_save_remaining() * TARGET_PAGE_SIZE / bwidth;
>
> - return expected_time <= migrate_max_downtime();
> + return expected_downtime <= migrate_max_downtime();
> }
> return 0;
> }
>
Reviewed-by: Orit Wasserman <address@hidden>
- [Qemu-devel] [PATCH v2 0/8] Migration stats, Juan Quintela, 2012/08/18
- [Qemu-devel] [PATCH 1/8] buffered_file: g_realloc() can't fail, Juan Quintela, 2012/08/18
- [Qemu-devel] [PATCH 2/8] fix migration sync, Juan Quintela, 2012/08/18
- [Qemu-devel] [PATCH 3/8] migration: move total_time from ram stats to migration info, Juan Quintela, 2012/08/18
- [Qemu-devel] [PATCH 4/8] migration: store end_time in a local variable, Juan Quintela, 2012/08/18
- [Qemu-devel] [PATCH 6/8] migration: rename expected_time to expected_downtime, Juan Quintela, 2012/08/18
- Re: [Qemu-devel] [PATCH 6/8] migration: rename expected_time to expected_downtime,
Orit Wasserman <=
- [Qemu-devel] [PATCH 7/8] migration: export migrate_get_current(), Juan Quintela, 2012/08/18
- [Qemu-devel] [PATCH 5/8] migration: print total downtime for final phase of migration, Juan Quintela, 2012/08/18
- [Qemu-devel] [PATCH 8/8] migration: print expected downtime in info migrate, Juan Quintela, 2012/08/18