[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 7/8] include core qdev code into *-user, too
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [RFC 7/8] include core qdev code into *-user, too |
Date: |
Tue, 21 Aug 2012 15:55:53 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Aug 21, 2012 at 05:59:22PM +0100, Peter Maydell wrote:
> On 21 August 2012 16:43, Eduardo Habkost <address@hidden> wrote:
> > The code depends on some functions from qemu-option.o, so add
> > qemu-option.o to qom-obj-y to make sure it's included.
> >
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
> > Makefile.objs | 1 +
> > hw/Makefile.objs | 2 +-
> > qom/Makefile.objs | 2 +-
> > hw/qdev-properties.c => qom/device-properties.c | 0
> > hw/qdev.c => qom/device.c | 0
> > 5 files changed, 3 insertions(+), 2 deletions(-)
> > rename hw/qdev-properties.c => qom/device-properties.c (100%)
> > rename hw/qdev.c => qom/device.c (100%)
> >
> > diff --git a/Makefile.objs b/Makefile.objs
> > index 4412757..2cf91c2 100644
> > --- a/Makefile.objs
> > +++ b/Makefile.objs
> > @@ -14,6 +14,7 @@ universal-obj-y += $(qobject-obj-y)
> > #######################################################################
> > # QOM
> > qom-obj-y = qom/
> > +qom-obj-y += qemu-option.o
>
> qemu-option.c isn't actually QOM related code...
True, but it's a dependency of the QOM DeviceState code. I don't know if
qom-obj-y is for "the QOM code" or "QOM code + dependencies".
I simply added it to qom-obj-y to avoid having to repeat myself
(otherwise I would need to add qemu-option.o to both common-obj-y and
user-obj-y).
--
Eduardo
- [Qemu-devel] [RFC 6/8] qdev: use full qdev.h include path on qdev*.c, (continued)
- [Qemu-devel] [RFC 6/8] qdev: use full qdev.h include path on qdev*.c, Eduardo Habkost, 2012/08/21
- [Qemu-devel] [RFC 1/8] move qemu_irq typedef out of cpu-common.h, Eduardo Habkost, 2012/08/21
- [Qemu-devel] [RFC 4/8] cleanup error.h, included qapi-types.h aready has stdbool.h, Eduardo Habkost, 2012/08/21
- [Qemu-devel] [RFC 7/8] include core qdev code into *-user, too, Eduardo Habkost, 2012/08/21
- [Qemu-devel] [RFC 3/8] qapi-types.h doesn't really need to include qemu-common.h, Eduardo Habkost, 2012/08/21
- [Qemu-devel] [RFC 2/8] qdev: split up header so it can be used in cpu.h, Eduardo Habkost, 2012/08/21
- [Qemu-devel] [RFC 5/8] split qdev into a core and code used only by qemu-system-*, Eduardo Habkost, 2012/08/21
- Re: [Qemu-devel] [RFC 0/8] include qdev core in *-user, make CPU child of DeviceState, Avi Kivity, 2012/08/22