[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler warning cau
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler warning caused by illegal type cast |
|
Date: |
Fri, 24 Aug 2012 10:16:49 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
Il 24/08/2012 10:31, Hannes Reinecke ha scritto:
>
>> Type casts from pointer to integer values must use uintptr_t
>> instead of unsigned long. Otherwise the compiler complains on
>> hosts with sizeof(pointer) != sizeof(long).
>>
>> The patch also replace magic number 32 by sizeof(info.serial_number)
>> which has the same value but is better for code reviews.
>>
>> Signed-off-by: Stefan Weil <address@hidden>
>
> Sigh. I never seem to get the hang of typecasting.
>
> Acked-by: Hannes Reinecke <address@hidden>
Nope, this needs to be fixed using the same scheme that you used for SAS
addresses. Quick before Anthony notices and disables MEGASAS. :)
Paolo