Re: [Qemu-devel] [PATCH ] lan9118: fix multicast filtering

[Aurelien Jarno]

On Fri, Aug 24, 2012 at 10:47:47AM +0100, Stefan Hajnoczi wrote:
> On Thu, Aug 23, 2012 at 4:39 PM, Aurelien Jarno <address@hidden> wrote:
> > The lan9118 emulation tries to compute the multicast index by calling
> > directly the crc32() function from zlib, but fails to get the correct
> > result.
> >
> > Use the common compute_mcast_idx() function instead, which gives the
> > correct result. This fixes IPv6 support.
> >
> > Signed-off-by: Aurelien Jarno <address@hidden>
> > ---
> >  hw/lan9118.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> There is another crc32() call in hw/lan9118.c:lan9118_receive().  Can
> that be replaced too and then #include <zlib.h> can be dropped?
> 

I don't think so, at least not easily. This is a different call (the
length is variable), and most emulated NICs have a call to crc32(), but
in slightly different ways.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net