[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq ea
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier |
Date: |
Fri, 24 Aug 2012 12:06:03 +0100 |
On 24 August 2012 11:54, Stefan Hajnoczi <address@hidden> wrote:
> On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
>> This allows using qemu_irq in the target specific cpu.h.
>>
>> Signed-off-by: Stefan Weil <address@hidden>
>> ---
>> qemu-common.h | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> I'm not sure if there's a reason why qemu_irq was previously hidden from
> cpu.h but the code change itself is fine and no one else has commented.
>
> Thanks, applied to the trivial patches tree:
> https://github.com/stefanha/qemu/commits/trivial-patches
Consensus seemed to be that it was better to move qemu_irq
into hw/irq.h, as discussed in this mail thread:
http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg03463.html
rather than just doing a move of the typedef within this header.
-- PMM