Re: [Qemu-devel] [PATCH] qxl: Add set_client_capabilities() interface to QXLInterface

[Gerd Hoffmann]

On 08/27/12 19:20, Søren Sandmann Pedersen wrote:
> From: Søren Sandmann Pedersen <address@hidden>
> 
> This new interface lets spice server inform the guest whether
> 
> (a) a client is connected
> (b) what capabilities the client has
> 
> There is a fixed number (464) of bits reserved for capabilities, and
> when the capabilities bits change, the QXL_INTERRUPT_CLIENT interrupt
> is generated.

Needs some #ifdefs to make sure qemu continues to build with old
spice-server versions.

>      case 3: /* qxl-3 */
> +     pci_device_rev = QXL_REVISION_STABLE_V10;
> +     io_size = msb_mask(QXL_IO_RANGE_SIZE * 2 - 1);
> +     break;
> +    case 5:

I think there is no need to jump to 5, we can use revision 4 for both
client capabilities and monitors config.

cheers,
  Gerd