|
| From: | Michael Tokarev |
| Subject: | Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment |
| Date: | Tue, 28 Aug 2012 11:35:57 +0400 |
| User-agent: | Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0.5) Gecko/20120624 Icedove/10.0.5 |
On 27.08.2012 22:56, Blue Swirl wrote:
[]
>> +static uint32_t slow_bar_readb(void *opaque, target_phys_addr_t addr)
>> +{
>> + AssignedDevRegion *d = opaque;
>> + uint8_t *in = d->u.r_virtbase + addr;
>
> Don't perform arithmetic with void pointers.
There are a few places in common qemu code which does this for a very
long time. So I guess it is safe now.
/mjt
| [Prev in Thread] | Current Thread | [Next in Thread] |