[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] HACKING: remove bogus restrictions
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PATCH] HACKING: remove bogus restrictions |
Date: |
Tue, 28 Aug 2012 19:01:16 +0300 |
We copied HACKING from libvirt but it has some bogus stuff:
neither underscore capital, double underscore, or underscore 't' suffixes
are reserved in Posix/C: this appears to be based on misreading of the
C standard. Using sane prefixes is enough to avoid conflicts.
These rules are also widely violated in our codebase,
and it does not make sense to rework it all, apparently for
no benefit.
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
HACKING | 4 ----
1 file changed, 4 deletions(-)
diff --git a/HACKING b/HACKING
index 471cf1d..0a941fc 100644
--- a/HACKING
+++ b/HACKING
@@ -69,10 +69,6 @@ it points to, or it is aliased to another pointer that is.
2.3. Typedefs
Typedefs are used to eliminate the redundant 'struct' keyword.
-2.4. Reserved namespaces in C and POSIX
-Underscore capital, double underscore, and underscore 't' suffixes should be
-avoided.
-
3. Low level memory management
Use of the malloc/free/realloc/calloc/valloc/memalign/posix_memalign
--
MST
Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions, Blue Swirl, 2012/08/28