[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.2 v2] target-xtensa: return ENOSYS for uni
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH for-1.2 v2] target-xtensa: return ENOSYS for unimplemented simcalls |
Date: |
Wed, 29 Aug 2012 10:38:09 +0100 |
On 22 August 2012 19:03, Max Filippov <address@hidden> wrote:
> --- a/target-xtensa/xtensa-semi.c
> +++ b/target-xtensa/xtensa-semi.c
> @@ -218,6 +218,8 @@ void HELPER(simcall)(CPUXtensaState *env)
>
> default:
> qemu_log("%s(%d): not implemented\n", __func__, regs[2]);
> + regs[2] = -1;
> + regs[3] = ENOSYS;
> break;
> }
This doesn't look right -- ENOSYS is a host errno, and may vary
between host OSes and CPU architectures. I would have thought you'd
want to return a value defined by whatever guest ABI we're
emulating here.
-- PMM