[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Fix buffer run out in eepro100.
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2] Fix buffer run out in eepro100. |
Date: |
Thu, 30 Aug 2012 08:26:04 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Aug 30, 2012 at 07:47:38AM +0800, Bo Yang wrote:
> On 08/29/2012 11:19 PM, Stefan Hajnoczi wrote:
> > On Wed, Aug 29, 2012 at 07:26:11PM +0800, Bo Yang wrote:
> >> This is reported by QA. When installing os with pxe, after the initial
> >> kernel and initrd are loaded, the procedure tries to copy files from
> >> install
> >> server to local harddisk, the network becomes stall because of running out
> >> of
> >> receive descriptor.
> >>
> >> Signed-off-by: Bo Yang <address@hidden>
> >> ---
> >> hw/eepro100.c | 5 ++++-
> >> 1 files changed, 4 insertions(+), 1 deletions(-)
> >
> > Thanks, applied to the net patches tree:
> > https://github.com/stefanha/qemu/commits/net
> >
> > I have reproduced the bug and tested that your patch fixes it. Your
> > patch also has tabs instead of spaces, I fixed that up when merging.
>
> Thanks for verifying and merging the patch. Sorry for my mistake in
> coding style. I'll be careful next time. I use vim, it looks like set
> tabstop=4 is not enough to get it work as expected.
set tabstop=4 " display tabs as 4 spaces
set expandtab " use spaces instead of tabs
set shiftwidth=4 " indent by 4 spaces