Re: [Qemu-devel] [PATCH 00/18] qapi: Convert savevm, loadvm, delvm and info snapshots

[Luiz Capitulino]

On Wed, 15 Aug 2012 09:41:41 +0200
Pavel Hrdina <address@hidden> wrote:

> This patch series convert these commands into qapi and intruduce QMP commands
> vm-snapshot-save, vm-snapshot-load, vm-snapshot-delete and query-vm-snapshots.
> It also rewrite error report for function used by these commands.

Unfortunately, most of the error conversions are wrong. I've commented on
them, but the most important thing here is to decide how we should propagate
the Error object in the block layer and what to do with its errno usage.

It's better to discuss this first before doing large changes. It might also be
worth it to split this series and work on error propagation first.

I've CC'ed the block layer guys in one of my reviews to this series.