[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/6] qemu-ga: Plug fd leak on ga_channel_listen_acce
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 4/6] qemu-ga: Plug fd leak on ga_channel_listen_accept() error path |
Date: |
Fri, 11 Jan 2013 11:25:00 +0100 |
Spotted by Coverity.
Signed-off-by: Markus Armbruster <address@hidden>
---
qga/channel-posix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qga/channel-posix.c b/qga/channel-posix.c
index d4fd628..5579185 100644
--- a/qga/channel-posix.c
+++ b/qga/channel-posix.c
@@ -45,6 +45,7 @@ static gboolean ga_channel_listen_accept(GIOChannel *channel,
ret = ga_channel_client_add(c, client_fd);
if (ret) {
g_warning("error setting up connection");
+ close(client_fd);
goto out;
}
accepted = true;
--
1.7.11.7
- [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups, Markus Armbruster, 2013/01/11
- [Qemu-devel] [PATCH 2/6] qemu-ga: Drop pointless lseek() from ga_open_pidfile(), Markus Armbruster, 2013/01/11
- [Qemu-devel] [PATCH 3/6] qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path, Markus Armbruster, 2013/01/11
- [Qemu-devel] [PATCH 1/6] qemu-ga: Document intentional fall through in channel_event_cb(), Markus Armbruster, 2013/01/11
- [Qemu-devel] [PATCH 5/6] qemu-ga: Plug fd leak on ga_channel_open() error paths, Markus Armbruster, 2013/01/11
- [Qemu-devel] [PATCH 4/6] qemu-ga: Plug fd leak on ga_channel_listen_accept() error path,
Markus Armbruster <=
- [Qemu-devel] [PATCH 6/6] qemu-ga: Handle errors uniformely in ga_channel_open(), Markus Armbruster, 2013/01/11
- Re: [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups, Eric Blake, 2013/01/11
- Re: [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups, Luiz Capitulino, 2013/01/14
- Re: [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups, mdroth, 2013/01/14