[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] target-mips: fix EXTPDP and setting up pos
|
From: |
Petar Jovanovic |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] target-mips: fix EXTPDP and setting up pos field in the DSPControl reg |
|
Date: |
Fri, 17 May 2013 17:55:35 +0000 |
________________________________________
From: Aurelien Jarno address@hidden
Sent: Friday, May 17, 2013 7:34 PM
To: Petar Jovanovic
Cc: address@hidden; Petar Jovanovic
Subject: Re: [PATCH 2/2] target-mips: fix EXTPDP and setting up pos field in
the DSPControl reg
I am not sure it is correct there for the 64-bit mode.
The value that should be written should be DSPcontrolpos6..0 - (size
+ 1), therefore keeeping only last 6 bits doesn't seems correct to me.
Given the change above, I think it should simply be
set_DSPControl_pos(sub, env);
----------
You are correct. I have submitted a second version of the patch.
Petar