[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/9] qapi.py: Decent syntax error reporting
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 4/9] qapi.py: Decent syntax error reporting |
|
Date: |
Fri, 26 Jul 2013 13:57:53 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/26/2013 01:48 PM, Paolo Bonzini wrote:
> Il 26/07/2013 21:33, Markus Armbruster ha scritto:
>>> Do we even want to allow TABs in the schema files? Right now, they are
>>> tab-free; if you error out here instead of futzing with tab width, we
>>> could forcefully maintain that property.
>>
>> I'm not volunteering for the TAB police, but if y'all want the parser to
>> reject TABs, I can do that.
>
> No, please don't. TAB is whitespace in JSON, and should be whitespace
> in schema files.
Good argument. Just because we don't use it now doesn't mean we have to
actively forbid it from future use; and the more we diverge from the
JSON spec, the more we are stuck maintaining our parser by hand.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 5/9] qapi.py: Reject invalid characters in schema file, Markus Armbruster, 2013/07/26
[Qemu-devel] [PATCH 8/9] qapi.py: Rename expr_eval to expr in parse_schema(), Markus Armbruster, 2013/07/26
[Qemu-devel] [PATCH 9/9] qapi.py: Permit comments starting anywhere on the line, Markus Armbruster, 2013/07/26
[Qemu-devel] [PATCH 7/9] qapi.py: Fix diagnosing non-objects at a schema's top-level, Markus Armbruster, 2013/07/26
[Qemu-devel] [PATCH 6/9] qapi.py: Fix schema parser to check syntax systematically, Markus Armbruster, 2013/07/26