[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCHv3 14/20] block/get_block_status: set *pnum = 0 on er
From: |
Peter Lieven |
Subject: |
[Qemu-devel] [PATCHv3 14/20] block/get_block_status: set *pnum = 0 on error |
Date: |
Tue, 24 Sep 2013 15:35:08 +0200 |
if the call is invoked through bdrv_is_allocated the caller might
expect *pnum = 0 on error. however, a new implementation of
bdrv_get_block_status might only return a negative exit value on
error while keeping *pnum untouched.
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Peter Lieven <address@hidden>
---
block.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block.c b/block.c
index 66b9eae..3499c90 100644
--- a/block.c
+++ b/block.c
@@ -3259,6 +3259,7 @@ static int64_t coroutine_fn
bdrv_co_get_block_status(BlockDriverState *bs,
ret = bs->drv->bdrv_co_get_block_status(bs, sector_num, nb_sectors, pnum);
if (ret < 0) {
+ *pnum = 0;
return ret;
}
--
1.7.9.5
- [Qemu-devel] [PATCHv3 02/20] block: add flags to bdrv_*_write_zeroes, (continued)
- [Qemu-devel] [PATCHv3 02/20] block: add flags to bdrv_*_write_zeroes, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 03/20] block: introduce BDRV_REQ_MAY_UNMAP request flag, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 05/20] block/raw: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 06/20] block: add BlockLimits structure to BlockDriverState, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 07/20] block: honour BlockLimits in bdrv_co_do_write_zeroes, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 08/20] block: honour BlockLimits in bdrv_co_discard, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 11/20] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 13/20] block: introduce bdrv_zeroize, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 12/20] iscsi: add bdrv_co_write_zeroes, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 10/20] iscsi: set limits in BlockDriverState, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 14/20] block/get_block_status: set *pnum = 0 on error,
Peter Lieven <=
- [Qemu-devel] [PATCHv3 09/20] iscsi: simplify iscsi_co_discard, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 16/20] block/get_block_status: avoid redundant callouts on raw devices, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 18/20] qemu-img: add support for fully allocated images, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 20/20] block/raw: copy BlockLimits on raw_open, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 15/20] block/get_block_status: avoid segfault if there is no backing_hd, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 17/20] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/09/24
- [Qemu-devel] [PATCHv3 19/20] qemu-img: conditionally zero out target on convert, Peter Lieven, 2013/09/24