[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3 06/20] block: add BlockLimits structure to Blo
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCHv3 06/20] block: add BlockLimits structure to BlockDriverState |
Date: |
Wed, 02 Oct 2013 09:53:01 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
On 09/24/2013 07:35 AM, Peter Lieven wrote:
> this patch adds BlockLimits which introduces discard and write_zeroes
> limits and alignment information to the BlockDriverState.
>
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> include/block/block_int.h | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> +struct BlockLimits {
Should this be a typedef? Either in include/qemu/typedefs.h (where
BlockDriverState is listed), or locally (see BdrvTrackedRequest in the
same file for an example)?
> @@ -280,6 +294,9 @@ struct BlockDriverState {
> uint64_t total_time_ns[BDRV_MAX_IOTYPE];
> uint64_t wr_highest_sector;
>
> + /* I/O Limits */
> + struct BlockLimits bl;
> +
All other struct/pointer-to-struct members in BlockDriverState are
listed by typedef name, rather than calling out 'struct foo'.
My question is one of style/consistency, not of C correctness; so unless
a maintainer actually agrees that a typedef change is needed so that you
comply with project coding standards, feel free to add:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCHv3 06/20] block: add BlockLimits structure to BlockDriverState,
Eric Blake <=