[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 0/5] Do not set SO_REUSEADDR on Windows
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH v6 0/5] Do not set SO_REUSEADDR on Windows |
Date: |
Wed, 02 Oct 2013 19:46:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.0 |
Am 02.10.2013 14:28, schrieb Eric Blake:
> On 10/02/2013 04:23 AM, Sebastian Ottlik wrote:
>> This patchset disables most uses of SO_REUSEADDR on Windows and
replaces it with
>> calls to the new function socket_set_fast_reuse. On Windows systems
the default
>> behaviour is equivalent to SO_REUSEADDR on other operating systems.
SO_REUSEADDR
>> can still be set but results in undesired behaviour in most cases. It
may even
>> lead to situations were system behaviour is unspecified. More
information on
>> this can be found at:
>> http://msdn.microsoft.com/en-us/library/windows/desktop/ms740621.aspx
>>
>> I originally encountered this issue when accidentally launching two QEMU
>> instances with identical GDB ports at the same time. In which case
QEMU won't
>> fail as one might expect.
>>
>> Note that patch #4 fails checkpatch.pl. This is intentional (see v3
changes).
>>
>> v6 Changes:
>> - dropped error output and the silent parameter in favor of an assertion
>>
>> Actually I wanted to remove the return value from the function too,
as the
>> assertion pretty much states that the function will not fail and
thus always
>> return 0. However this would make the code a little ugly to prevent
unused
>> variable warnings if NDEBUG is set (see patch 1) and also would
require some
>> ugly changes to slirp/socket.c (see patch 4). Thus I decided to
keep it.
>>
>> - Rebased to current master (a684f3cf9b9b9c3cb82be87aafc463de8974610c)
>>
>
> Series: Reviewed-by: Eric Blake <address@hidden>
Thanks for the patches and for the review.
I applied all to my mingw patch queue and have sent a pull request.
Stefan
- [Qemu-devel] [PATCH v6 0/5] Do not set SO_REUSEADDR on Windows, Sebastian Ottlik, 2013/10/02
- [Qemu-devel] [PATCH v6 1/5] util: add socket_set_fast_reuse function which will replace setting SO_REUSEADDR, Sebastian Ottlik, 2013/10/02
- [Qemu-devel] [PATCH v6 5/5] util: call socket_set_fast_reuse instead of setting SO_REUSEADDR, Sebastian Ottlik, 2013/10/02
- [Qemu-devel] [PATCH v6 4/5] slirp: call socket_set_fast_reuse instead of setting SO_REUSEADDR, Sebastian Ottlik, 2013/10/02
- [Qemu-devel] [PATCH v6 2/5] gdbstub: call socket_set_fast_reuse instead of setting SO_REUSEADDR, Sebastian Ottlik, 2013/10/02
- [Qemu-devel] [PATCH v6 3/5] net: call socket_set_fast_reuse instead of setting SO_REUSEADDR, Sebastian Ottlik, 2013/10/02
- Re: [Qemu-devel] [PATCH v6 0/5] Do not set SO_REUSEADDR on Windows, Eric Blake, 2013/10/02
- Re: [Qemu-devel] [PATCH v6 0/5] Do not set SO_REUSEADDR on Windows,
Stefan Weil <=