[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] .gitmodules: use upstream SeaBIOS repo to f
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] .gitmodules: use upstream SeaBIOS repo to fix submodule init |
Date: |
Thu, 03 Oct 2013 10:45:25 +0100 |
User-agent: |
mu4e 0.9.9.5; emacs 24.3.1 |
address@hidden writes:
> On 3 October 2013 17:58, <address@hidden> wrote:
>> From: Alex Bennée <address@hidden>
>>
>> Currently master is broken as the wanted commit doesn't exist in
>> qemu's mirror of SeaBIOS.
<snip>
> This is wrong. QEMU's submodules should all point to
> git.qemu.org. Among other things our release source
> tarballs pull in the sources and it's a good way to ensure
> it's all consistent and we definitely have version controlled
> copies of the sources we release under our control rather
> than just in an external repo.
Fair enough, I'll drop the patch.
> What should actually happen is that Anthony should fix
> his workflow to ensure that he doesn't commit patches
> which update submodules without also updating the
> qemu.org mirrors of the external repos :-)
Of course once this is merged it will flag up the problem right away
(even sooner if the pull request is a github one ;-)
--
Alex Bennée