Re: [Qemu-devel] [PATCH] linux-user: define ipc_perm and shmid_ds per arch and fix shmctl issue

[Petar Jovanovic]

________________________________________
From: Peter Maydell address@hidden
Sent: Monday, October 07, 2013 6:08 PM
To: Petar Jovanovic
Cc: QEMU Developers; Riku Voipio; Petar Jovanovic; Aurelien Jarno
Subject: Re: [Qemu-devel] [PATCH] linux-user: define ipc_perm and shmid_ds per 
arch and fix shmctl issue

> It's much harder to review the code changes for the do_shmctl changes
> when they're swamped by the code motion for making the structs per-arch.

Making the structs per-arch is part of the fix, this is why these changes
are joined. But yes, I can split the change in two, though they will not be
self-sufficient.

> Rather than adding another big ifdef ladder to syscall_defs.h, I think
> we should create a new file linux-user/$arch/target_structs.h
> for each target arch as a place to put "depends on the architecture"
> struct definitions.

Sure, I do not mind if everyone is in favour of that. This means adding 17
new files though.

Regards,
Petar