[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qcow2: Use pread for inactive L1 in overlap che
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH] qcow2: Use pread for inactive L1 in overlap check |
|
Date: |
Wed, 9 Oct 2013 11:43:13 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 09.10.2013 um 10:42 hat Max Reitz geschrieben:
> Currently, qcow2_check_metadata_overlap uses bdrv_read to read inactive
> L1 tables from disk. The number of sectors to read is calculated through
> a truncating integer division, therefore, if the L1 table size is not a
> multiple of the sector size, the final entries will not be read and
> their entries in memory remain undefined (from the g_malloc).
> Using bdrv_pread fixes this.
>
> Signed-off-by: Max Reitz <address@hidden>
Thanks, applied to the block branch.
Kevin