[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 8/8] vfio-pci: Fix endian issues in vfio_pci_size_
From: |
Alex Williamson |
Subject: |
[Qemu-devel] [PULL v2 8/8] vfio-pci: Fix endian issues in vfio_pci_size_rom() |
Date: |
Thu, 10 Oct 2013 12:45:12 -0600 |
User-agent: |
StGit/0.16 |
VFIO is always little endian so do byte swapping of our mask on the
way in and byte swapping of the size on the way out.
Signed-off-by: Alex Williamson <address@hidden>
Reported-by: Alexey Kardashevskiy <address@hidden>
---
hw/misc/vfio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
index 1fbc40b..a2d5283 100644
--- a/hw/misc/vfio.c
+++ b/hw/misc/vfio.c
@@ -1141,7 +1141,7 @@ static const MemoryRegionOps vfio_rom_ops = {
static void vfio_pci_size_rom(VFIODevice *vdev)
{
- uint32_t orig, size = (uint32_t)PCI_ROM_ADDRESS_MASK;
+ uint32_t orig, size = cpu_to_le32((uint32_t)PCI_ROM_ADDRESS_MASK);
off_t offset = vdev->config_offset + PCI_ROM_ADDRESS;
char name[32];
@@ -1163,7 +1163,7 @@ static void vfio_pci_size_rom(VFIODevice *vdev)
return;
}
- size = ~(size & PCI_ROM_ADDRESS_MASK) + 1;
+ size = ~(le32_to_cpu(size) & PCI_ROM_ADDRESS_MASK) + 1;
if (!size) {
return;
- [Qemu-devel] [PULL v2 0/8] VFIO updates for QEMU, Alex Williamson, 2013/10/10
- [Qemu-devel] [PULL v2 1/8] vfio-pci: Add support for MSI affinity, Alex Williamson, 2013/10/10
- [Qemu-devel] [PULL v2 2/8] vfio-pci: Test device reset capabilities, Alex Williamson, 2013/10/10
- [Qemu-devel] [PULL v2 3/8] vfio-pci: Lazy PCI option ROM loading, Alex Williamson, 2013/10/10
- [Qemu-devel] [PULL v2 4/8] vfio-pci: Cleanup error_reports, Alex Williamson, 2013/10/10
- [Qemu-devel] [PULL v2 5/8] vfio-pci: Implement PCI hot reset, Alex Williamson, 2013/10/10
- [Qemu-devel] [PULL v2 6/8] vfio: Fix debug output for int128 values, Alex Williamson, 2013/10/10
- [Qemu-devel] [PULL v2 7/8] vfio-pci: Add dummy PCI ROM write accessor, Alex Williamson, 2013/10/10
- [Qemu-devel] [PULL v2 8/8] vfio-pci: Fix endian issues in vfio_pci_size_rom(),
Alex Williamson <=