[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/5] block/raw-posix: Employ error parameter
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 2/5] block/raw-posix: Employ error parameter |
Date: |
Fri, 11 Oct 2013 11:07:40 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 10.10.2013 um 15:44 hat Max Reitz geschrieben:
> Make use of the error parameter in the opening and creating functions in
> block/raw-posix.c.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/raw-posix.c | 60
> ++++++++++++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 48 insertions(+), 12 deletions(-)
You forgot updating a raw_open_common() caller which is compiled out
on your system. Builds will fail on FreeBSD now.
> @@ -1059,12 +1069,15 @@ static int raw_create(const char *filename,
> QEMUOptionParameter *options,
> fd = qemu_open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY,
> 0644);
> if (fd < 0) {
> + error_setg_errno(errp, errno, "Could not create file");
> result = -errno;
Doesn't error_setg_errno() change the value of errno? (More instances
follow.)
Kevin
- [Qemu-devel] [PATCH 0/5] block: Employ error parameter, Max Reitz, 2013/10/10
- [Qemu-devel] [PATCH 1/5] block/raw_bsd: Employ error parameter, Max Reitz, 2013/10/10
- [Qemu-devel] [PATCH 2/5] block/raw-posix: Employ error parameter, Max Reitz, 2013/10/10
- [Qemu-devel] [PATCH 3/5] block/raw-win32: Employ error parameter, Max Reitz, 2013/10/10
- [Qemu-devel] [PATCH 4/5] blkdebug: Employ error parameter, Max Reitz, 2013/10/10
- [Qemu-devel] [PATCH 5/5] blkverify: Employ error parameter, Max Reitz, 2013/10/10
- Re: [Qemu-devel] [PATCH 0/5] block: Employ error parameter, Eric Blake, 2013/10/10
- Re: [Qemu-devel] [PATCH 0/5] block: Employ error parameter, Kevin Wolf, 2013/10/11