[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] vring: factor common code for error exits
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] vring: factor common code for error exits |
Date: |
Fri, 11 Oct 2013 11:19:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 10/10/2013 22:53, Richard Henderson ha scritto:
> On 10/10/2013 08:07 AM, Paolo Bonzini wrote:
>> return head;
>> +
>> +out:
>> + assert(ret < 0);
>> + if (ret == -EFAULT) {
>> + vring->broken = true;
>> + }
>> + return ret;
>
> If this is only the error path, can we call the
> label something other than "out"?
Yes. Though I think it does not matter if the function returns a zero
or positive result after the next patch, so it can become a general exit
label too.
Paolo