[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support |
Date: |
Tue, 15 Oct 2013 17:35:30 +0300 |
On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote:
> Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto:
> > - VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2, vmstate_pci_status,
> > - struct pci_status),
> > + VMSTATE_STRUCT_TEST(pci0_status, PIIX4PMState,
> > + vmstate_test_no_use_acpi_pci_hotplug,
> > + 2, vmstate_pci_status,
> > + struct pci_status),
>
> There's no reason to remove this from the stream when a new machine type
> is in use. You'll just send out zeroes.
Seemed cleaner not to.
> > + VMSTATE_PCI_HOTPLUG(acpi_pci_hotplug, PIIX4PMState,
> > + vmstate_test_use_acpi_pci_hotplug),
>
> This works, but it is a bit different from other cases that are already
> present, which use a subsection. It is a bit ugly because it looks like
> a version-1 field, but in fact it is not version 1.
>
> I'll let other people decide whether it's acceptable or not, but I'm
> leaning towards asking you to use a subsection.
>
> Paolo
- [Qemu-devel] [PULL 37/43] i386: ACPI table generation code from seabios, (continued)
- [Qemu-devel] [PULL 37/43] i386: ACPI table generation code from seabios, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 38/43] ssdt: fix PBLK length, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 39/43] ssdt-proc: update generated file, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 40/43] pci: add pci_for_each_bus_depth_first, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 41/43] pcihp: generalization of piix4 acpi, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 43/43] acpi-build: enable hotplug for PCI bridges, Michael S. Tsirkin, 2013/10/14
- [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support, Michael S. Tsirkin, 2013/10/14
- Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support, Paolo Bonzini, 2013/10/15
- Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support, Paolo Bonzini, 2013/10/15
- Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support, Michael S. Tsirkin, 2013/10/15
- Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support, Paolo Bonzini, 2013/10/15
- Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support, Michael S. Tsirkin, 2013/10/15
- Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support, Paolo Bonzini, 2013/10/15
- Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support, Michael S. Tsirkin, 2013/10/15
- Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support, Anthony Liguori, 2013/10/15
- Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support, Michael S. Tsirkin, 2013/10/15
- Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support, Paolo Bonzini, 2013/10/16
- Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support, Anthony Liguori, 2013/10/16