[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qcow2: Unset zero_beyond_eof in save_vmstate
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] qcow2: Unset zero_beyond_eof in save_vmstate |
Date: |
Thu, 24 Oct 2013 11:52:30 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 21.10.2013 um 22:37 hat Eric Blake geschrieben:
> On 10/20/2013 08:52 PM, Max Reitz wrote:
> > Saving the VM state is done using bdrv_pwrite. This function may perform
> > a read-modify-write, which in this case results in data being read from
> > beyond the end of the virtual disk. Since we are actually trying to
> > access an area which is not a part of the virtual disk, zero_beyond_eof
> > has to be set to false before performing the partial write, otherwise
> > the VM state may become corrupted.
> >
> > Signed-off-by: Max Reitz <address@hidden>
> > ---
> > Follow-up to (depends on):
> > - qcow2: Restore total_sectors value in save_vmstate
>
> Reviewed-by: Eric Blake <address@hidden>
Thanks, applied to the block branch.
Kevin