[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix COR by disabling BDRV_O_COPY_ON_READ before
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] Fix COR by disabling BDRV_O_COPY_ON_READ before opening the backing_file. |
Date: |
Tue, 29 Oct 2013 12:56:28 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 26.10.2013 um 15:31 hat Max Reitz geschrieben:
> Am 25.10.2013 02:15, schrieb Thibaut LAURENT:
> > Since commit 0ebd24e0a203cf2852c310b59fbe050190dc6c8c,
> > bdrv_open_common will throw an error when trying to open a file
> > read-only with the BDRV_O_COPY_ON_READ flag set.
> > Although BDRV_O_RDWR is unset for the backing files,
> > BDRV_O_COPY_ON_READ is still passed on if copy-on-read was requested
> > for the drive. Let's unset this flag too before opening the backing
> > file, or bdrv_open_common will fail.
> >
> > Signed-off-by: Thibaut LAURENT <address@hidden>
> > ---
> > block.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Reviewed-by: Max Reitz <address@hidden>
Thanks, applied to the block branch. (And thanks for CCing me, Max, I
would have missed the patch otherwise.)
Kevin