[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] util/error: Save errno from clobbering
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] util/error: Save errno from clobbering |
Date: |
Fri, 8 Nov 2013 15:54:05 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Nov 07, 2013 at 08:10:29PM +0100, Max Reitz wrote:
> There may be calls to error_setg() and especially error_setg_errno()
> which blindly (and until now wrongly) assume these functions not to
> clobber errno (e.g., they pass errno to error_setg_errno() and return
> -errno afterwards). Instead of trying to find and fix all of these
> constructs, just make sure error_setg() and error_setg_errno() indeed do
> not clobber errno.
>
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> util/error.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next
Stefan