[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] qemu-iotests: Allow caller to disable under
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/4] qemu-iotests: Allow caller to disable underscore convertion for qmp |
|
Date: |
Wed, 29 Jan 2014 07:09:58 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/29/2014 01:40 AM, Fam Zheng wrote:
s/convertion/conversion/ in the subject
> QMP command "block_set_io_throttle" expects underscores in parameters
> instead of dashes: {iops,bps}_{rd,wr,max}.
>
> Add optional argument conv_keys (defaults to True, backward compatible),
> it will be used in IO throttling test case.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> tests/qemu-iotests/iotests.py | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
You know, it might be nice to get the '-'/'_' looseness into QMP itself
when invoked via JSON strings over the monitor, rather than just the
testsuite wrapper, since we're already inconsistent in several commands.
But that's a bigger project for another day.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature