[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 07/14] Add 'debug-threads' suboption to --name
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL v3 07/14] Add 'debug-threads' suboption to --name |
Date: |
Sun, 9 Mar 2014 21:19:56 +0200 |
From: "Dr. David Alan Gilbert" <address@hidden>
Add flag storage to qemu-thread-* to store the namethreads flag
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
---
include/qemu/thread.h | 1 +
util/qemu-thread-posix.c | 7 +++++++
util/qemu-thread-win32.c | 8 ++++++++
vl.c | 9 +++++++++
qemu-options.hx | 7 +++++--
5 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/include/qemu/thread.h b/include/qemu/thread.h
index 3e32c65..bf1e110 100644
--- a/include/qemu/thread.h
+++ b/include/qemu/thread.h
@@ -59,5 +59,6 @@ void *qemu_thread_join(QemuThread *thread);
void qemu_thread_get_self(QemuThread *thread);
bool qemu_thread_is_self(QemuThread *thread);
void qemu_thread_exit(void *retval);
+void qemu_thread_naming(bool enable);
#endif
diff --git a/util/qemu-thread-posix.c b/util/qemu-thread-posix.c
index 37dd298..0fa6c81 100644
--- a/util/qemu-thread-posix.c
+++ b/util/qemu-thread-posix.c
@@ -27,6 +27,13 @@
#include "qemu/thread.h"
#include "qemu/atomic.h"
+static bool name_threads;
+
+void qemu_thread_naming(bool enable)
+{
+ name_threads = enable;
+}
+
static void error_exit(int err, const char *msg)
{
fprintf(stderr, "qemu: %s: %s\n", msg, strerror(err));
diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c
index 27a5217..e42cb77 100644
--- a/util/qemu-thread-win32.c
+++ b/util/qemu-thread-win32.c
@@ -16,6 +16,14 @@
#include <assert.h>
#include <limits.h>
+static bool name_threads;
+
+void qemu_thread_naming(bool enable)
+{
+ /* But note we don't actually name them on Windows yet */
+ name_threads = enable;
+}
+
static void error_exit(int err, const char *msg)
{
char *pstr;
diff --git a/vl.c b/vl.c
index 44b5ad3..c8a5bfa 100644
--- a/vl.c
+++ b/vl.c
@@ -495,6 +495,12 @@ static QemuOptsList qemu_name_opts = {
.name = "process",
.type = QEMU_OPT_STRING,
.help = "Sets the name of the QEMU process, as shown in top etc",
+ }, {
+ .name = "debug-threads",
+ .type = QEMU_OPT_BOOL,
+ .help = "When enabled, name the individual threads; defaults
off.\n"
+ "NOTE: The thread names are for debugging and not a\n"
+ "stable API.",
},
{ /* End of list */ }
},
@@ -954,6 +960,9 @@ static void parse_name(QemuOpts *opts)
{
const char *proc_name;
+ if (qemu_opt_get(opts, "debug-threads")) {
+ qemu_thread_naming(qemu_opt_get_bool(opts, "debug-threads", false));
+ }
qemu_name = qemu_opt_get(opts, "guest");
proc_name = qemu_opt_get(opts, "process");
diff --git a/qemu-options.hx b/qemu-options.hx
index 56e5fdf..068da2d 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -328,9 +328,11 @@ possible drivers and properties, use @code{-device help}
and
ETEXI
DEF("name", HAS_ARG, QEMU_OPTION_name,
- "-name string1[,process=string2]\n"
+ "-name string1[,process=string2][,debug-threads=on|off]\n"
" set the name of the guest\n"
- " string1 sets the window title and string2 the process
name (on Linux)\n",
+ " string1 sets the window title and string2 the process
name (on Linux)\n"
+ " When debug-threads is enabled, individual threads are
given a separate name (on Linux)\n"
+ " NOTE: The thread names are for debugging and not a stable
API.\n",
QEMU_ARCH_ALL)
STEXI
@item -name @var{name}
@@ -339,6 +341,7 @@ Sets the @var{name} of the guest.
This name will be displayed in the SDL window caption.
The @var{name} will also be used for the VNC server.
Also optionally set the top visible process name in Linux.
+Naming of individual threads can also be enabled on Linux to aid debugging.
ETEXI
DEF("uuid", HAS_ARG, QEMU_OPTION_uuid,
--
MST
- [Qemu-devel] [PULL v3 04/14] memory_region_present: return false if address is not found in child MemoryRegion, (continued)
- [Qemu-devel] [PULL v3 04/14] memory_region_present: return false if address is not found in child MemoryRegion, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 06/14] Rework --name to use QemuOpts, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 05/14] PCIE: fix regression with coldplugged multifunction device, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 08/14] Add a 'name' parameter to qemu_thread_create, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 09/14] MAINTAINERS: drop an out of date address, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 10/14] acpi-test: retain both asl and aml files on failure, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 11/14] acpi-test: issue errors instead of warnings when possible, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 12/14] pam: partly fix write-only mode, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 13/14] pckbd: return 'keyboard enabled' on read input port command, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 14/14] qemu: x86: ignore ioapic polarity, Michael S. Tsirkin, 2014/03/09
- [Qemu-devel] [PULL v3 07/14] Add 'debug-threads' suboption to --name,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Peter Maydell, 2014/03/10
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Michael S. Tsirkin, 2014/03/10
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Peter Maydell, 2014/03/11
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Michael S. Tsirkin, 2014/03/11
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Peter Maydell, 2014/03/11
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Michael S. Tsirkin, 2014/03/11
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Peter Maydell, 2014/03/11
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Michael S. Tsirkin, 2014/03/11
- Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes, Peter Maydell, 2014/03/11