Re: [Qemu-devel] [PATCH v2 0/4] input: add support for kbd delays

[Dave Mielke]

[quoted lines by Gerd Hoffmann on 2014/06/02 at 13:28 +0200]

Hi:

>Little series of four input patches.  

Yes, it all seems to work correctly, now, with these four patches applied.

Perhaps there should be a common constant that all the delay calls use. Maybe 
even a variable which defaults to 10 and is set by something like the -k delay= 
in my patch. That'd allow users to modify it if it isn't quite right in some 
other circumstance, as well as to reduce it to 0 if they perceive a need to do 
so.

It might be a good idea to introduce an intermediate call which doesn't have a 
"length of delay" argument, which then calls the current function with the 
desired value.

These are, of course, cosmetic suggestions. The code as it now stands dodes 
work.

-- 
Dave Mielke           | 2213 Fox Crescent | The Bible is the very Word of God.
Phone: 1-613-726-0014 | Ottawa, Ontario   | http://Mielke.cc/bible/
EMail: address@hidden | Canada  K2A 1H7   | http://FamilyRadio.com/