[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-img: Document check exit codes
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-img: Document check exit codes |
Date: |
Mon, 02 Jun 2014 13:45:49 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 06/02/2014 01:31 PM, Max Reitz wrote:
> The exit code 63 (check not supported by image format) was not even
> documented in the comment above the check command in the source code;
> add it, as it does indeed seem useful.
>
> Also, document all of check's exit codes in the manpage.
>
> Signed-off-by: Max Reitz <address@hidden>
> Reported-by: Markus Armbruster <address@hidden>
> ---
> qemu-img.c | 9 +++++----
> qemu-img.texi | 23 +++++++++++++++++++++++
> 2 files changed, 28 insertions(+), 4 deletions(-)
>
> +In case the image does not have any inconsistencies, check exits with
> @code{0}.
> +Other exit codes indicate the kind of inconsistency found or if another error
> +occured. The following table summarizes all exit codes of the check
> subcommand:
s/occured/occurred/
> +
> +If @code{-r} is specified, exit codes representing the image state refer to
> the
> +state after (the attempt on) repairing it. That is, a successful @code{-r
> all}
Not sure if this reads better, but:
s/attempt on/attempt at/
With the spelling fix,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature