Re: [Qemu-devel] [PATCH 0/5] fix building with musl libc

[Natanael Copa]

On Wed, 4 Jun 2014 00:37:44 +0100
Peter Maydell <address@hidden> wrote:

> On 29 April 2014 15:17, Natanael Copa <address@hidden> wrote:
> > In addition to the previoiusly sent "linux-user: avoid using glibc
> > internals in _syscall5 and in definition of target_sigevent struct",
> > those are needed for making qemu build with musl libc on Alpine Linux.
> >
> > There is still 2 missing fcntl.h definitions (F_EXLCK and F_SHLCK) but
> > those should probably be defined in libc so patch for that is not
> > included here.
> >
> > Natanael Copa (5):
> >   util/qemu-openpty: fix build with musl libc by include termios.h as
> >     fallback
> >   xen: replace ffsl with ctzl
> >   vhost: replace ffsl with ctzl
> >   exec: replace ffsl with ctzl
> >   linux-user/signal.c: define __SIGRTMIN/MAX for non-GNU platforms
> 
> Hmm. I just noticed these ffsl patches didn't get committed (the BSDs
> don't like ffsl either). There were issues with patch 5( the signal.c one)
> but 1..4 are good (and get my Reviewed-by: as well as Paolo's).
> 
> I'm currently building up a tree with various bsd-user fixes in it,
> so I'll take these through that, I think. (Patch 1 is arguably slightly
> out of scope for that but better to keep it together with 2..4.)
> 
> Natanael: you might want to update the signal.c patch to accommodate
> review comments and resubmit it.
> 
> thanks

I will try get it done today. Thanks!

-nc

> -- PMM