Re: [Qemu-devel] [PATCH v2 0/9] usb: usb host adapter hotplug

[Gonglei (Arei)]

> -----Original Message-----
> From: Gerd Hoffmann [mailto:address@hidden
> Sent: Wednesday, June 04, 2014 2:12 PM
> To: Gonglei (Arei)
> Cc: address@hidden; Luonengjun; Huangweidong (C); Huangpeng
> (Peter)
> Subject: Re: [PATCH v2 0/9] usb: usb host adapter hotplug
> 
>   Hi,
> 
> > changes since v1:
> >  * add more completely resource cleanup for every usb host adapter.
> 
> Looks good overall.  How did you test this?
> 
Thanks!

The steps of tested:
1. start a vm using below qemu command line:
./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name win7 -boot c -drive 
file=/mnt/sdb/gonglei/image/win7_32_2U -vnc 0.0.0.0:10 -monitor stdio

2. hot-plug/unplug an usb host adapters:
2.1) For ehci:
(qemu) device_add usb-ehci,id=ehci
(qemu) device_add usb-tablet,id=input0,bus=ehci.0,port=1
(qemu) device_del ehci
2.2) For uhci:
(qemu) device_add piix3-usb-uhci,id=uhci
(qemu) device_del uhci
2.3) For uhci:
(qemu) device_add pci-ohci,id=ohci
(qemu) device_del ohci
2.4) For uhci:
(qemu) device_add nec-usb-xhci,id=xhci
(qemu) device_del xhci 

3. do step #2 repeating, more than 20 times.

BTW, I will add some qtestes for usb host adapters hot-plug/unplug later,
and add tracing for exit function.


Best regards,
-Gonglei