Re: [Qemu-devel] [PATCH] target-microblaze: Delete unused sign_extend() function

[Edgar E. Iglesias]

On Tue, Jun 03, 2014 at 06:59:21PM +0100, Peter Maydell wrote:
> The sign_extend() function is unused; delete it.

Reviewed-by: Edgar E. Iglesias <address@hidden>

Peter, feel free to push this straight in.

Thanks,
Edgar

> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> We have sextract() for this these days anyway.
> ---
>  target-microblaze/translate.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c
> index 488df2d..50c214b 100644
> --- a/target-microblaze/translate.c
> +++ b/target-microblaze/translate.c
> @@ -98,19 +98,6 @@ static const char *special_regnames[] =
>      "sr16", "sr17", "sr18"
>  };
>  
> -/* Sign extend at translation time.  */
> -static inline int sign_extend(unsigned int val, unsigned int width)
> -{
> -        int sval;
> -
> -        /* LSL.  */
> -        val <<= 31 - width;
> -        sval = val;
> -        /* ASR.  */
> -        sval >>= 31 - width;
> -        return sval;
> -}
> -
>  static inline void t_sync_flags(DisasContext *dc)
>  {
>      /* Synch the tb dependent flags between translator and runtime.  */
> -- 
> 1.9.2
>