Re: [Qemu-devel] [PATCH v2 4/6] target-arm: add emulation of PSCI calls for system emulation

[Peter Maydell]

On 4 June 2014 11:09, Rob Herring <address@hidden> wrote:
> On Tue, Jun 3, 2014 at 6:14 AM, Peter Maydell <address@hidden> wrote:
>> This won't build on non-Linux hosts: you can't assume
>> the linux-headers/ includes are available except within
>> code guarded by CONFIG_KVM.
>
> What do you suggest doing here then. Really, psci.h is OS independent.
> Can we copy it to somewhere else in the qemu tree?

Only if you can guarantee that it won't clash with the one that is
in the linux-headers/ tree, or the one in /usr/include, ie that it
doesn't matter which of those three we pick up. That pretty much
means "kernel KVM headers can't ever rely on new PSCI
constants being added to psci.h" so that doesn't seem like it's
going to work. Otherwise it would need to be
copy-and-rename-symbols, same as we do for anything else
where we need them outside the KVM code. I agree that's pretty
ugly.

thanks
-- PMM