[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/5] qapi: Extract qapi/common.json definitio
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/5] qapi: Extract qapi/common.json definitions |
Date: |
Thu, 05 Jun 2014 09:16:54 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 06/05/2014 05:45 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <address@hidden>
> ---
> qapi-schema.json | 87 ++----------------------------------------------------
> qapi/common.json | 89
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 91 insertions(+), 85 deletions(-)
> create mode 100644 qapi/common.json
Reviewed-by: Eric Blake <address@hidden>
Much nicer. Here's the intra-diff showing that the motion is fairly
straightforward:
$ diff -u <(sed -n 's/^-//p' patch1) \
<(sed -n 's/^\+//p' patch1)
--- /dev/fd/63 2014-06-05 09:15:37.189091311 -0600
+++ /dev/fd/62 2014-06-05 09:15:37.190091308 -0600
@@ -1,5 +1,11 @@
---
--- a/qapi-schema.json
+++ b/qapi-schema.json
+# QAPI common definitions
+{ 'include': 'qapi/common.json' }
+++ b/qapi/common.json
+# -*- Mode: Python -*-
+#
+# QAPI common definitions
+
##
# @ErrorClass
#
@@ -26,6 +32,7 @@
'data': [ 'GenericError', 'CommandNotFound', 'DeviceEncrypted',
'DeviceNotActive', 'DeviceNotFound', 'KVMMissingCap' ] }
+##
# @VersionInfo:
#
# A description of QEMU's version.
@@ -84,6 +91,3 @@
##
{ 'command': 'query-commands', 'returns': ['CommandInfo'] }
-##
--- /dev/null
--
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/5] Extract QAPI block commands, Benoît Canet, 2014/06/05
- [Qemu-devel] [PATCH v2 1/5] qapi: Extract qapi/common.json definitions, Benoît Canet, 2014/06/05
- Re: [Qemu-devel] [PATCH v2 1/5] qapi: Extract qapi/common.json definitions,
Eric Blake <=
- [Qemu-devel] [PATCH v2 4/5] qapi: Extract qapi/block.json definitions, Benoît Canet, 2014/06/05
- [Qemu-devel] [PATCH v2 2/5] qapi: create two block related json modules, Benoît Canet, 2014/06/05
- [Qemu-devel] [PATCH v2 5/5] qapi: Set QAPI descriptions files under the GPL V2 license, Benoît Canet, 2014/06/05
- [Qemu-devel] [PATCH v2 3/5] qapi: Extract qapi/block-core.json definitions, Benoît Canet, 2014/06/05
- Re: [Qemu-devel] [PATCH v2 0/5] Extract QAPI block commands, Eric Blake, 2014/06/05