[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/2] qdev: Display warning about unused -glob
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/2] qdev: Display warning about unused -global |
Date: |
Thu, 5 Jun 2014 19:21:34 +0300 |
On Mon, May 05, 2014 at 02:03:05PM -0400, Don Slutz wrote:
> I might have named this v2, but since this is a split out of:
>
> [PATCH v3 2/4] GlobalProperty: Display warning about unused -global
>
> From:
>
> [PATCH v3 0/4] Add max-ram-below-4g (was Add pci_hole_min_size machine option)
>
> I feel v4 is better.
Applied, thanks!
> Changes v3 to v4:
> Add a new patch to add a check in test-qdev-global-props.c
> Changed qdev_prop_check_global() to return state. Only used
> by unit test.
> Change to use error_report().
>
> Andreas Färber:
> Added hotpluggable checking.
> Renamed to qdev:
>
> Did not do:
> Add a separate linked list:
> This looked to me to increase the complexity without any benefit.
> Adjust where vl.c calls qdev_prop_check_global().
> Since this is just before migration starts, I still think this
> is the best place. I did a quick look into adding some test
> that checks that this is still working, but only found qemu-iotest
> doing the QEMU output check for expected output. It did not
> make sense to me to add a global property check there.
>
> Paolo Bonzini:
> Added a comment before definition of the not_used field.
>
>
>
> Don Slutz (2):
> qdev: Display warning about unused -global
> qdev: Add test of qdev_prop_check_global
>
> hw/core/qdev-properties-system.c | 16 ++++++++++++++++
> hw/core/qdev-properties.c | 18 ++++++++++++++++++
> include/hw/qdev-core.h | 8 ++++++++
> include/hw/qdev-properties.h | 1 +
> tests/test-qdev-global-props.c | 4 ++++
> vl.c | 2 ++
> 6 files changed, 49 insertions(+)
>
> --
> 1.8.4
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v4 0/2] qdev: Display warning about unused -global,
Michael S. Tsirkin <=