qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/1] configure: unset interfering variables


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 1/1] configure: unset interfering variables
Date: Fri, 06 Jun 2014 10:11:27 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Il 06/06/2014 09:41, Cornelia Huck ha scritto:
On Wed, 28 May 2014 12:39:17 +0200
Cornelia Huck <address@hidden> wrote:

The check for big or little endianness relies on grep reporting
match/non-match on the generated binary. If the user specified
--binary-files=without-match in their GREP_OPTIONS, this will fail.

Let's follow what autoconf does and unset GREP_OPTIONS and CLICOLOR_FORCE
at the beginning of the script.

Reported-by: Eugene (jno) Dvurechenski <address@hidden>
Suggested-by: Markus Armbruster <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
 configure | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/configure b/configure
index 0e516f9..525da56 100755
--- a/configure
+++ b/configure
@@ -3,6 +3,11 @@
 # qemu configure script (c) 2003 Fabrice Bellard
 #

+# Unset some variables known to interfere with behavior of common tools,
+# just as autoconf does.
+CLICOLOR_FORCE= GREP_OPTIONS=
+unset CLICOLOR_FORCE GREP_OPTIONS
+
 # Temporary directory used for files created while
 # configure runs. Since it is in the build directory
 # we can safely blow away any previous version of it

Is there an obvious tree to merge configure changes through, or should
I just throw it into my next s390 pull request?

Hi,

I picked up this patch and will push it to a "configure" branch on github.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]